Topic: Inventory count error while adding cards... and several other things

Hi,

I've added cards to my inventory during the past few days (yesterday night included) and I noticed some annoying bugs which are related to the ones other people have already talked about. I usually add cards using the "Add card" button, entering the card name, pressing "Enter", but this doesn't really matter here.

Note: some of the bugs I have noticed over the past few days might already have been fixed, I admit I haven't checked if there were all fixed already, and took notes every time I encountered something weird. So if they are, just skip it, and sorry smile

The main bugs I encountered were:

  • using the "Set editor", I tried to add Plains to some edition. Not willing to click 20 times the "+" button, I clicked on the green box to directly add 20 elements in the Inventory Widget. I could see one line per expansions I already own Plains for, but no expansion symbol were visible. I decided to "Add new row" and add my new Plains. The result was quite interesting: ALL the Plains in my inventory were converted to the expansion I tried to add Plains to! (yes, that is a lot). [note: it seems to have been fixed over the week-end]

  • a few hours later when I started over counting and adding Plains, I used the "+" button for each one, sometime having to correct my mistakes (adding 5 instead of 4 for instance) by going to the card page, inventory widget and then clicking the "-" button or changing the amount directly in the green box. But this didn't go well either: it sometimes (I did reproduce it but not on purpose) multiplicated the number of cards I had, because it somewhat duplicated the row in the inventory widget: for instance, if I had 7 Plains, the next time I reloaded the page or the inventory widget, I would have 14, then 21, etc. It's like the lines wouldn't merge and it created duplicates everywhere.

  • I also had the bug (already reported) of the "ghost" lines with 0 cards (which was very annoying too). To make them disappear from the Inventory widget/"add card" page, I had to fully reload it (F5) and then enter my card name again. Only clicking on "Save & Close" and then re-entering the card name hadn't any effect.

I have also a few other things to report, which seem to be malfunctioning for some time now:

  • The "+"/"-" buttons is a neat idea, however the button is so small and so close to either the "Split" one or the other "+"/"-" of the other boxes (wishlist/tradelist) that it it difficult to use it efficiently. Moreover, it sometimes "lags" when I click multiple times on it, resulting in the wrong amount of cards being added (do you make a query to the db every time someone clicks?).

  • As a consequence, the "Split" button is most of the time difficult to click, since the cursor will trigger the "+" button of the inventory (I use Firefox)

  • There is a weird (cosmetic) behavior when you add cards from the inventory page: the order of the cards with the same name is not fixed, obviously because they must be saved in a data structure which doesn't allow sorting. Just click "Add cards", type any name (I have turned "QuickAdd Mode" off) and click repeatedly on "Save": you'll see cards with the same name being sorted differently every time you click smile. This has no consequence on the integrity of the data, but it's funny (and well, if you can fix it and sort cards by condition descending for instance ?).

  • When you hover over expansion symbols in the inventory, there is no infotip telling you what expansion it is. This is a little bit annoying for "generic" expansion symbol (the red thing) which is used for things like "Foreign Black Bordered" or "Collector's Edition" for instance.

  • Why don't you offer to sort the "add card" widget by expansion (and then by set number and then condition)? It's currently sorted by date of last modification descending and it's quite annoying when you are trying to find out what card you are missing in you basic lands inventory when you have like 100 rows big_smile

  • When selecting an expansion for a card, why not putting the "default setting" on top of the list? For instance, if I want to add "Plains version 1" from Amonkhet, I set the default settings to Amonkhet, then click "add new row". I now want to add "Plains version 2" from Amonkhet: I click again on "add new row" which adds me the version 1 (which is normal), I then click on the expansion symbol and the list I'm proposed is sorted chronologically, TBD first and I have to type "am" to get to Amonkhet again.

  • Would it be possible/feasible to add a "-" button on the set page? I know there are some constraints like "what if the user has set the defaults as "AKH - English - Foil" and there are no cards matching this?

By the way, I've been using Deckbox for a few years now (I guess 6?) and to me it is still the easiest and most comprehensive (and independant!) site around, and thank you very much for your work smile

ack

Re: Inventory count error while adding cards... and several other things

Thanks for the detailed feedback, will be looking through this. I changed a couple of things today, more to come.

Are you seeing any of the reported issues with the details panel still happening? I deployed a fix on saturday that I thought fixed those (the ones in the main bugs section). Did you see any of them since then?

Re: Inventory count error while adding cards... and several other things

Thanks for your reply sebi!

I think the 3 main bugs I encountered are all at least partly fixed (the 1st one for sure is fixed!): when I use the "Add card" button and I split cards count in the panel and click "save", it still doesn't merge similare cards (same edition/language/condition/special) as it used to do, and if I put "0" as the count and click "save", the "0" line still appears (what I called "ghost" line). I have to search again for the card for it to merge or delete the ghost line.
However it works flawlessly on a card page, using the inventory panel on the left side!

I didn't manage to trigger the duplication again, which is good news, so it seems to be only cosmetic now, but can lead to errors when entering many cards of the same type.

Re: Inventory count error while adding cards... and several other things

I feel like the second issue ack mentioned (duplicating cards, if I understood correctly) is still a thing. Here's a log of actions I took with an empty Deckbox inventory.

1. Hit "Add cards" button
2. Type Vaporkin, hit enter. 1 Theros Vaporkin is in my inventory (as expected).
3. Hit "Add New Row" button
4. Change the added Vaporkin row to Conspiracy, increase number to 3. Hit Save. 1 Theros and 3 Conspiracy Vaporkins in my inventory. (As Expected)
5. Hit "Add New Row" button
6. Increase number of Theros Vaporkins in the newly added row to 3. Hit Save. Now there are two rows of 3 Conspiracy Vaporkins each in my inventory (for a total of six, although only 3 were added in step 4), along with 4 Theros (as expected).

Inventory now lists 10 cards, 3 distinct. (Expected 7 cards, 2 distinct)

Last edited by orpheus (2020-04-15 18:25:07)

Re: Inventory count error while adding cards... and several other things

Interesting, it looks like the bug I triggered this week-end, at least I recognize a workflow I had.
However, I tried to reproduce the exact same steps as you but didn't get the same result. But mine was not what I expected either:

https://i.ibb.co/WPJk8J7/inventory-bug.jpg

Even though I reload the page, I'll see those 2 lines for the same card/expansion/language/condition and they will not merge...

Re: Inventory count error while adding cards... and several other things

Thanks guys for the detailed info. Should be finally fixed now.

Re: Inventory count error while adding cards... and several other things

I still have the double lines when I do:
- "Add Card"
- then for the same card "Add new row"
- "Save"

However, if I use the "+"/"-" buttons, the rows are merged as intended.

Re: Inventory count error while adding cards... and several other things

FYI, the line merge as intended when I do the following:
- I am in QuickAdd mode, then everything goes fine, whatever I try to do
- I am not in QuickAdd mode, then if I click multiple times on "Add new row" before clicking on "Save", rows are not merged. I have to add another row and click "Save" again for them to merge or use the "+"/"-" buttons or directly edit the number of cards in the green box.

The correct behavior only happens when I click "Save" somewhere in the middle of my inventory listing and I add rows afterwards (or use other features to add cards than "Add new row". To summarize: if the last action I do is "Save" and I only used the "Add new row" button, then nothing is merged.

I suppose the QuickAdd mode does an action similar to "Add new row" + "Save" so it works everytime.